Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new metrics for RabbitMQ plugin #6963

Closed
byjg opened this issue Jan 31, 2020 · 2 comments · Fixed by #7084
Closed

Add new metrics for RabbitMQ plugin #6963

byjg opened this issue Jan 31, 2020 · 2 comments · Fixed by #7084
Labels
area/rabbitmq feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@byjg
Copy link
Contributor

byjg commented Jan 31, 2020

Feature Request

I would like to add new metrics for RabbitMQ plugin

Proposal:

Add the metrics

  • slave_nodes_len
  • synchronised_slave_nodes_len

These metrics by default return a string list with the name of the nodes, however we can extract the length of these list and push it.

Current behavior:

The metrics proposed don't exist.

Desired behavior:

Return these metrics as the number of items in the list.

Use case:

When a message is out of sync we get the value "NaN" in the metric "messages" from the rabbitmq api. However it is not handled well in telegraf. The idea here is know that a queue is out of sync by analyzing the values returned by the proposed metrics: slave_nodes_len and synchronised_slave_nodes_len

If the idea makes sense for telegraf I already implemented it and I can open a PR.

byjg added a commit to byjg/telegraf that referenced this issue Feb 3, 2020
@danielnelson danielnelson added the feature request Requests for new plugin and for new features to existing plugins label Feb 25, 2020
@danielnelson
Copy link
Contributor

Yes, would love to see a pull request. I to fit in best we would probably leave the _len suffix off: slave_nodes=42i or slave_node_count=42i

byjg added a commit to byjg/telegraf that referenced this issue Feb 25, 2020
byjg added a commit to byjg/telegraf that referenced this issue Feb 25, 2020
@byjg
Copy link
Contributor Author

byjg commented Feb 25, 2020

Thank you :)

@byjg byjg closed this as completed Feb 26, 2020
@danielnelson danielnelson added this to the 1.14.0 milestone Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rabbitmq feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants