Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis plugin doesn't get Commandstats #2894

Closed
marek-knappe opened this issue Jun 7, 2017 · 3 comments
Closed

Redis plugin doesn't get Commandstats #2894

marek-knappe opened this issue Jun 7, 2017 · 3 comments
Labels
area/redis feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Milestone

Comments

@marek-knappe
Copy link

marek-knappe commented Jun 7, 2017

Feature Request

redis plugin is just doing 'Info' instead of 'INFO ALL' Which doesn't get Commandstats.

Proposal:

https://github.com/influxdata/telegraf/blob/master/plugins/inputs/redis/redis.go#L135

Change INFO to INFO ALL

Current behavior:

No commandstats

Desired behavior:

Commandstats
cmdstat_get:calls=18708243,usec=81317810,usec_per_call=4.35
cmdstat_setnx:calls=12,usec=53,usec_per_call=4.42
cmdstat_setex:calls=1342574,usec=6917848,usec_per_call=5.15
cmdstat_del:calls=28393,usec=224118,usec_per_call=7.89
cmdstat_mget:calls=3136449,usec=24200188,usec_per_call=7.72
cmdstat_mset:calls=118074,usec=830158,usec_per_call=7.03
cmdstat_select:calls=252265,usec=371753,usec_per_call=1.47
cmdstat_expire:calls=524193,usec=811227,usec_per_call=1.55
cmdstat_info:calls=7734,usec=1128518,usec_per_call=145.92

Use case: [Why is this important (helps with prioritizing requests)]

Easy change, adding more data to info, didn't see any problems with performence.

@danielnelson
Copy link
Contributor

Sounds good, can you open a PR?

@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 8, 2017
marek-knappe added a commit to marek-knappe/telegraf that referenced this issue Jun 9, 2017
marek-knappe added a commit to marek-knappe/telegraf that referenced this issue Jun 9, 2017
marek-knappe added a commit to marek-knappe/telegraf that referenced this issue Jun 9, 2017
@marek-knappe
Copy link
Author

Done.

@danielnelson danielnelson added this to the 1.4.0 milestone Jun 9, 2017
@danielnelson danielnelson modified the milestones: 1.4.0, 1.5.0 Aug 14, 2017
@danielnelson danielnelson modified the milestones: 1.5.0, 1.6.0 Nov 29, 2017
@danielnelson danielnelson modified the milestones: 1.6.0, 1.7.0 Jan 27, 2018
@danielnelson danielnelson modified the milestones: 1.7.0, 1.8.0 Jun 3, 2018
@russorat russorat modified the milestones: 1.8.0, 1.9.0 Sep 4, 2018
@russorat russorat modified the milestones: 1.9.0, 1.10 Oct 22, 2018
@russorat russorat modified the milestones: 1.10.0, 1.11.0 Jan 14, 2019
@danielnelson danielnelson modified the milestones: 1.11.0, 1.12.0 May 24, 2019
@danielnelson
Copy link
Contributor

Added in #5926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redis feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

No branches or pull requests

3 participants