-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why does procstat plugin store PID as a tag? #1460
Comments
I agree this should probably be a field, cc @daviesalex @sebito91 |
I think this is basically the same issue as #1451 albeit with a different proposed fix. We do need to fix this, for sure. Moving to a field is one thing, but searching on tags is convenient - but if you only do this for processes. I'll add this comment to that issue |
Also, boring fact that turned out to be relevant for us when we moved to RHEL, pid_max can be set to PID_MAX_LIMIT which is 2^22 in modern kernels by default. The default is now 32768; it was lower in older kernels. |
Hi,I'm also hitting this bug, I have around 150000 uniques values in pid tag (and around 2000 hosts in host tag). |
I have found that have the cardinality problem because of this. |
in release 1.2 you will be able to drop the pid using a config option in the plugin |
Seems like the process ID should be a field not a tag, in order to reduce series cardinality. I'm not sure I see a compelling use case for
GROUP BY pid
, given that over time each process name could generate over 32000 series. Ifpid
was a field it would still be possible to search for a specific PID, although regex doesn't work on fields.The text was updated successfully, but these errors were encountered: