Refactor logging system to use structured logging #7060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66e58d9 to
8a3e042
Compare
| select { | ||
| case <-signalCh: | ||
| m.Logger.Println("second signal received, initializing hard shutdown") | ||
| log.Warn("second signal received, initializing hard shutdown") |
There was a problem hiding this comment.
I don't think either of these are warn or error. You 100% want all of them to show up in your log, regardless of log level. I think they should all be info.
There was a problem hiding this comment.
I know we don't particularly want to use warn very much, but I do think this is a reasonable place to use it. A second signal could end up getting received by an automated system and it would be important information to know that, say, systemd needed to use a hard shutdown.
Add a custom log formatter to match our output conventions and colorize the terminal output when run interactively. Includes colors, spacing, and output of actual timestamps rather than seconds since the program started.
8a3e042 to
894436a
Compare
|
We'll be revisiting this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a custom log formatter to match our output conventions and colorize
the terminal output when run interactively. Includes colors, spacing,
and output of actual timestamps rather than seconds since the program
started.
Fixes #7036.