Spill out query and database detail at the time of bug report, to help r... #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p reproduction of bugs.
jvshahid
pushed a commit
that referenced
this pull request
Aug 12, 2014
jvshahid
pushed a commit
that referenced
this pull request
Aug 12, 2014
[Fix #47] Clean up external interface.
mgattozzi
added a commit
that referenced
this pull request
Feb 10, 2025
This commit adds a FileIndex to the compactor. This lets us index values for column names passed into the compactor function by being able to look up the path for the name of the file. Future work will need to be done for path rewriting in the index if parquet files are moved to different paths. For now it provides us an index of the files as they are written out into object storage. This commit does a few things: - The compactor now returns a struct with ParquetFile data, a FileIndex, and the necessary Object Store Paths from the compactor - Provides a method to index a record batch passed into it - Extends our compactor tests to include assertions for the indexes - Changes the FileIndex to use a combined key for one lookup, rather than two lookups and two maps, simplifying it's logic With these changes we can now create an index as we compact for queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...eproduction of bugs.