Fix alias, maintain column sort order #3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Get the distinct fields across all mappers. | ||
| var selectFields, aliasFields []string | ||
| if e.stmt.HasWildcard() { | ||
| sf := newStringSet() |
There was a problem hiding this comment.
Should this still be a stringset? What about select mean(value), max(value) from foo?
There was a problem hiding this comment.
For select * a stringSet works perfect as it gets you the distinct fields sorted alphabetically. It's when it wasn't a select * that the problem was encountered, and what this PR fixes.
select mean(value), max(value) from foo scenario works and is tested with this test:
5f9d9df to
9c1e4e0
Compare
|
+1 |
1 similar comment
|
+1 |
corylanou
added a commit
that referenced
this pull request
Aug 6, 2015
Fix alias, maintain column sort order
This was referenced Aug 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple issues.
Aliasing was no longer working per this issue:
Fixes #3530
Also, we were not maintaining column select order in our results. For example, if we issued
select foo, bar from bazthe column order in the return would bebar, foo, notfoo, bar. This is now corrected.