feat: backport values written metric to 1.8 #19445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ayang64
commented
Aug 26, 2020
•
- CHANGELOG.md updated with a link to the PR (not the Issue)
- Well-formatted commit messages
- Rebased/mergeable
- Tests pass
* feat(engine/tsm1): Add WritePointsWithContext() Add WritePontsWithContext() and make WritePoints() a thin wrapper for it. The purpose is to add statistics context values that we'll use to propagate the number of fields and points written to calls up the call chain. * feat(tsdb): Add WriteToShardWithContext() When applied, this patch adds WriteToShardWithContext() and wraps it with WriteToShard() to preserve the API. The the purpose of this addition is to propagate a context.Context value to Shard.WritePointsWithContext(). * feat(tsdb/shard): Add WritePointsWithContext() The purpose of adding WritePointsWithContext() is to propage context values down to engine code and propage statistics via the context.Value up to callers. This patch also adds values written statistics to the shard. * feat(http): Gather values written stats WritePointsWithContext() was added to propagate context values down to the engine and communicate stats to the caller. * feat(http): Gather values written stats WritePointsWithContext() was added to propagate context values down to the engine and communicate stats to the caller. * refactor: Change MetricKey to ContextKey This patch gives the type we're useing for context keys a better name.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.