Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): change source buckets from slice to obj #12677

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

kelwang
Copy link
Contributor

@kelwang kelwang commented Mar 18, 2019

Closes #12674

fixed the response, manually tested as well

  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@kelwang kelwang force-pushed the swagger_resource_buckets branch from 20d0812 to 0a3c303 Compare March 18, 2019 16:03
http/api_handler.go Outdated Show resolved Hide resolved
Copy link
Contributor

@imogenkinsman imogenkinsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but see comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants