Fix/org filter #12040
Merged
Fix/org filter #12040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f8e2c6 to
1ef583e
Compare
|
@goller looks like you'll need to rebase your commits on my branch to remove the other commits that are polluting this PR. I have recently rebased my branch to the latest master. |
52daccb to
7f72207
Compare
|
Hey @stuartcarnie ... rebased! |
stuartcarnie
approved these changes
Feb 21, 2019
|
@goller apparently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12010
Briefly describe your proposed changes:
Add checks and test coverage to FindOrganization with no filters set.
Add a "SimpleQuery" to just run a query and get the bytes.
Update swagger to document orgID/org parameters.
I'd also recommend we remove FluxService, FluxQueryService and probably a variety of endpoints that are not used or confusing.