Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert TagValueSeriesIDCache to use string fields. #11829

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Convert TagValueSeriesIDCache to use string fields. #11829

merged 1 commit into from
Feb 12, 2019

Conversation

benbjohnson
Copy link
Contributor

This commit changes name, key, and value to from []byte to string.

@benbjohnson benbjohnson added this to the 1.8 milestone Feb 12, 2019
@benbjohnson benbjohnson self-assigned this Feb 12, 2019
@benbjohnson benbjohnson requested a review from e-dard February 12, 2019 21:14
@benbjohnson
Convert TagValueSeriesIDCache to use string fields.
6e52264 
This commit changes `name`, `key`, and `value` to from `[]byte`
to `string`.
@benbjohnson benbjohnson force-pushed the bj-tag-cache-string-1.8 branch from b8369e9 to 6e52264 Compare February 12, 2019 21:22
e-dard
e-dard approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@benbjohnson benbjohnson mentioned this pull request Feb 12, 2019
Merged
@benbjohnson benbjohnson merged commit 8c491ce into 1.8 Feb 12, 2019
@benbjohnson benbjohnson mentioned this pull request Feb 12, 2019
Merged
@benbjohnson benbjohnson deleted the bj-tag-cache-string-1.8 branch February 12, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebo zeebo zeebo approved these changes

@e-dard e-dard e-dard approved these changes

Assignees

@benbjohnson benbjohnson

Labels
kind/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@benbjohnson @zeebo @e-dard