Limit force-full and cold compaction size. #10536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-dard
reviewed
Dec 5, 2018
tsdb/engine/tsm1/compact.go
Outdated
| @@ -453,11 +453,11 @@ func (c *DefaultPlanner) Plan(lastWrite time.Time) []CompactionGroup { | |||
| return nil | |||
| } | |||
|
|
|||
| group := []CompactionGroup{tsmFiles} | |||
| if !c.acquire(group) { | |||
| groups := splitCompactionGroups(tsmFiles, 4) | |||
There was a problem hiding this comment.
Can we make 4 a constant somewhere up top? I wonder if 4 is also too low.
|
@benbjohnson iIf we're doing as forced full compaction and we don't compact all the files in the shard then I think we would need to keep the We don't want a forced full compaction to result in not all the TSM files being compacted down. |
2e88d03 to
168a020
Compare
This commit limits the number of files that can be compacted in a single group when forcing a full compaction or when a shard becomes cold. This is to prevent too many files being compacted at the same time.
168a020 to
40db64d
Compare
|
@e-dard Ready for re-review. |
|
@e-dard I verified that the cold compaction eventually processes all the files (in groups of 8) and compacts them down to a single file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request limits the number of files that can be compacted in a single group when forcing a full compaction or when a shard becomes cold. This is to prevent too many files being compacted at the same time.