Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf dependency needs to be updated #19269

Closed
rockstar opened this issue Aug 10, 2020 · 2 comments
Closed

protobuf dependency needs to be updated #19269

rockstar opened this issue Aug 10, 2020 · 2 comments

Comments

@rockstar
Copy link
Contributor

rockstar commented Aug 10, 2020 •
edited
Loading

When trying to update influxdb to flux v0.78.0, the protobuf dependency was updated from 1.3.1 to 1.4.2. This raised a deprecation issue where github is no longer the authoritative source, and also requires some API changes to influxdb. The upgrade also appears to change the marshalling format for protobufs, so wasn't an easy change to make. This is all captured in #19264

In flux, support for BigTable merged (influxdata/flux#2925), which brought updated dependencies, forcing the protobuf update. That PR will be reverted temporarily, and its changes will be blocked until this issue can be addressed.
@rockstar rockstar mentioned this issue Aug 10, 2020
Merged
@alespour alespour mentioned this issue Aug 13, 2020
Merged
1 task
@timhallinflux
Copy link
Contributor

@rockstar -- ready to re-review this?

@rockstar
Copy link
Contributor Author

This was just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rockstar @timhallinflux