Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlib/sql): add BigQuery support (with no protobuf dep update in influxdb) #3116

Merged
merged 9 commits into from
Aug 31, 2020

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Aug 13, 2020

This PR add BigQuery support to sql package.

The previous PR (#2925) caused unwanted protobuf dependency update in InfluxDB repo (influxdata/influxdb#19264, influxdata/influxdb#19269).
This PR uses "influxdb compatibility" bigquery driver version v0.3.4-1.4.0, which depends on cloud.google.com/go/bigquery@v1.4.0 which depends on github.com/golang/protobuf@v1.3.2. In addition to that, dependency on cloud.google.com/go v0.57.0 was downgraded to v0.52.0.
These two version changes should keep

	github.com/golang/mock v1.3.1
	github.com/golang/protobuf v1.3.3

dependencies mentioned in influxdata/influxdb#19264 intact.

There are no other changes from #2925.

Done checklist

  • Test cases written

@codecov-commenter
Copy link

Codecov Report

Merging #3116 into master will increase coverage by 0.30%.
The diff coverage is 51.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3116      +/-   ##
==========================================
+ Coverage   51.75%   52.06%   +0.30%     
==========================================
  Files         332      333       +1     
  Lines       41398    41502     +104     
==========================================
+ Hits        21426    21608     +182     
+ Misses      17511    17417      -94     
- Partials     2461     2477      +16     
Impacted Files Coverage Δ
stdlib/sql/bigquery.go 45.65% <45.65%> (ø)
stdlib/sql/from.go 33.62% <100.00%> (+1.16%) ⬆️
stdlib/sql/source_validator.go 78.94% <100.00%> (+3.43%) ⬆️
stdlib/sql/to.go 45.56% <100.00%> (+0.44%) ⬆️
stdlib/sql/mysql.go 42.47% <0.00%> (+1.76%) ⬆️
stdlib/sql/postgres.go 48.48% <0.00%> (+2.02%) ⬆️
stdlib/sql/mssql.go 53.19% <0.00%> (+28.36%) ⬆️
stdlib/sql/snowflake.go 44.03% <0.00%> (+40.36%) ⬆️
stdlib/sql/awsathena.go 43.47% <0.00%> (+43.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be25922...63a9595. Read the comment docs.

@alespour alespour marked this pull request as ready for review August 13, 2020 13:41
Copy link
Contributor

@rockstar rockstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp, as this code has been reviewed before, and the only relevant change was to not update protobuf.

@rockstar rockstar merged commit 7ea0431 into influxdata:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants