feat: add username and password login #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candrewlee14
reviewed
Jul 5, 2022
clients/signin/signin.go
Outdated
| }) | ||
| res, err := client.SigninApi.PostSignin(ctx).ExecuteWithHttpInfo() | ||
| if err != nil { | ||
| return "", err |
There was a problem hiding this comment.
Maybe if an error happens here, you could again print to the user that this is only supported for OSS, in case that clarifies their problem. What does the error look like when you try to make this request to cloud?
There was a problem hiding this comment.
It simply 404s because cloud tries to do some redirect stuff that we don't follow. I can wrap this error with a suggestion to make sure its not running against cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for a user to login to InfluxDB using a username and password rather than a token. A user can specify both the username and password to be saved and used for all requests. Or, a user can specify just the username and they will be prompted for the password each time.
Note: this feature is OSS only