chore: fix issues with Go 1.18 in CI #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor function name
e535b78 to
07117f8
Compare
serenibyss
commented
Jun 27, 2022
| func strFactory(arg interface{}) *string { | ||
| val := (arg.(string)) // Docker image runs Go 1.17, so we can't use generics here. | ||
| return &val | ||
| func ptrFactory[T any](arg T) *T { |
There was a problem hiding this comment.
This change is mainly to show that Go 1.18 features work fine in a CI environment
jeffreyssmith2nd
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up Go version handling and removes some workarounds that are no longer needed since we are on Go 1.18