Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: automatically generate changelog #349

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Conversation

williamhbaker
Copy link
Contributor

Closes #324

Other than the changelog job, this required providing specific names for the test binaries generated for the various platforms. Otherwise the workspace could not be mounted in the release job due to multiple jobs having concurrently added files with the same name to the workspace.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@@ -11,6 +11,10 @@ dist/
# Test binary, built with `go test -c`
*.test

# Directories mounted during the release process in CI
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise gorelease errors out due to a dirty git state

release:
disable: true
changelog:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% necessary, but might be helpful to prevent confusion due to the generate goreleaser CHANGELOG, which is not relevant since we are generating our own.

Copy link

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williamhbaker williamhbaker merged commit 5cd1c9d into main Jan 10, 2022
@williamhbaker williamhbaker deleted the wb-auto-changelog-324 branch January 10, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate CHANGELOG generation
2 participants