-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contrib/qxip/hash): add sha1, md5, base64, hmac #5371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lmangani! A few minor suggestions on the docs, but this looks great.
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Co-authored-by: Scott Anderson <sanderson@users.noreply.github.com>
Thank you so much @sanderson! Next attempt in line is an S3 HTTP client for flux 100% made in flux 🤞 |
@sanderson @gavincabbage I'm going into paranoid mode temporarily: building with the latest flux master causes the following error, which seems related to this PR. I'm not sure if this is just about how I'm building my binary, but I'd rather be safe than sorry:
Did I miss something in the new code? The previous hash contrib was working fine. Apologies in advance! |
@lmangani I think you need to regenerate the stdlib before you build. > go generate ./stdlib ./libflux/go/libflux
> make generate |
I think this could be caused by me building using the master for the go library and a release (v0.192.0) as the library (or vice versa) which does not include yet the changes? As long as this is a build issue only on my side, all is well... Thanks @sanderson |
This PR extends the
contrib/qxip/hash
package with additional functions forsha1
,base64
,md5
,hmac
Note: The primary goal of this extension is powering flux native extensions dealing with auth token calculation etc. (ie: s3 client we're working on) without having to use or import additional go code.