Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update iox.sql to detect midstream errors #5350

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

wolffcm
Copy link

@wolffcm wolffcm commented Dec 17, 2022

This updates the IOx client abstraction to produce a reader that has an Err() method (which the Flight implementation does), and updates the implementation of iox.sql to check it for errors.

Prior to this change, midstream errors would be ignored and the result would be truncated.

These changes address a defect found in the cloud product, with tests added to the PR there.

BREAKING CHANGE: breaks the Go API for the IOx client dependency.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code (see above)
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/ (N/A)
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@wolffcm wolffcm requested a review from a team as a code owner December 17, 2022 16:13
@wolffcm wolffcm requested review from nathanielc and removed request for a team December 17, 2022 16:13
BREAKING CHANGE: Flux's abstraction for IOx's client is changing.
@wolffcm wolffcm force-pushed the wolffcm/iox-sql-midstream-error branch from df79295 to b7801f3 Compare December 17, 2022 16:14
@wolffcm wolffcm merged commit 72e6d38 into master Dec 19, 2022
@wolffcm wolffcm deleted the wolffcm/iox-sql-midstream-error branch December 19, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants