Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't include the opening parenthesis in invalid call expressions #5184

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Sep 9, 2022

Thought this would be necessary for influxdata/flux-lsp#580 but it seems like the completions works regardless. Still, this corrects expect_or_skip since I'd say we shouldn't use the token if we "skip" it.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@Marwes Marwes requested a review from a team as a code owner September 9, 2022 14:49
@Marwes Marwes requested review from nathanielc and removed request for a team September 9, 2022 14:49
These no longer include the end of the token that this failed on
@Marwes Marwes merged commit 50bab1b into master Sep 12, 2022
@Marwes Marwes deleted the parse_call_error branch September 12, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants