Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display yields in fluxtest #5161

Merged
merged 1 commit into from
Sep 5, 2022
Merged

feat: Display yields in fluxtest #5161

merged 1 commit into from
Sep 5, 2022

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Sep 2, 2022

It is useful to be able to insert yield(name: ...) to inspect a test but the output of the yield were just ignored. This collects and displays the output without causing any test failures due to this extra output.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • [x ] 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

It is useful to be able to insert `yield(name: ...)` to inspect a test but the output of the yield were just ignored. This collects and displays the output without causing any test failures due to this extra output.
@Marwes Marwes requested a review from a team as a code owner September 2, 2022 13:46
@Marwes Marwes requested review from onelson and removed request for a team September 2, 2022 13:46
@Marwes Marwes merged commit a1ed087 into master Sep 5, 2022
@Marwes Marwes deleted the yield_testcase branch September 5, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants