Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fill): correct type for fillValueTime #5156

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Conversation

scbrickley
Copy link
Contributor

@scbrickley scbrickley commented Sep 1, 2022

Closes #5127

fill() was incorrectly setting fillValueTime as an int64, which caused a panic the next time fillTimeColumn was called and tried to coerce fillValueTime into a values.Time. This only manifested when processing a table that spanned multiple table chunks (i.e., when fillTimeColumn was called with a fillValue that was already set).

This patch sets fillValueTime to be a values.Time, which avoids the bad type coercion and thereby also avoids the panic.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@scbrickley scbrickley marked this pull request as ready for review September 1, 2022 17:15
@scbrickley scbrickley requested a review from a team as a code owner September 1, 2022 17:15
@scbrickley scbrickley requested review from Marwes and removed request for a team September 1, 2022 17:15
@scbrickley scbrickley merged commit efa48eb into master Sep 6, 2022
@jacobmarble jacobmarble deleted the join-fill-panic branch January 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic with outer join and fill + usePrevious
2 participants