fix(fill): correct type for fillValueTime #5156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5127
fill()
was incorrectly settingfillValueTime
as an int64, which caused a panic the next timefillTimeColumn
was called and tried to coercefillValueTime
into avalues.Time
. This only manifested when processing a table that spanned multiple table chunks (i.e., whenfillTimeColumn
was called with afillValue
that was already set).This patch sets
fillValueTime
to be avalues.Time
, which avoids the bad type coercion and thereby also avoids the panic.Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/
docs/Spec.md
has been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.