Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass filename to the flux parser to get it printed in location #5057

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

skartikey
Copy link
Contributor

Currently, we print only the start and end locations of the ast.
with this change, the filename will be included in the location print.

required in #5039 to print
duplicate existing test with filename in the location.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

At the moment we print only the start and end location of the ast.
with this change filename will be included in the location print.

requred in #5039 to print
duplicate existing test with filename in the location.
@skartikey skartikey requested a review from a team as a code owner August 9, 2022 13:52
@skartikey skartikey requested review from jsternberg and removed request for a team August 9, 2022 13:52
@skartikey skartikey merged commit 391f320 into master Aug 10, 2022
@skartikey skartikey deleted the skartikey-flux-fluxtest-fileName branch August 10, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants