feat: remove vectorizedConst feature flag #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbrickley
approved these changes
Aug 8, 2022
onelson
pushed a commit
that referenced
this pull request
Aug 15, 2022
5 tasks
onelson
pushed a commit
that referenced
this pull request
Aug 16, 2022
onelson
pushed a commit
that referenced
this pull request
Aug 16, 2022
* chore: revert removal of vectorizedConst flag Revert of <#5054> * chore: make generate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #4985
Removes the feature flag which would allow/prevent literals from vectorizing.
Existing tests continue to pass, which is to say, we have the same behavior we did with the flag set to "enabled."
#4985 can be closed after this is merged, released and configcat is updated to remove the defunct flag.
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/N/Adocs/Spec.mdhas been updated N/ADear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.