feat: add rust binary to sit on top of "headless repl" backend #5041

Westonside · 2022-08-02T21:32:11Z

Description

Added in my rusty line code from my other repo. The rustyline will send the user input to the headless repl over JSON RPC via the stdin and receive output from the stdout. The rustyline also provides completion suggestions through communication over the stdio with the flux lsp. Related to #5040.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

✏️ Write a PR description, regardless of triviality, to include the value of this PR
🔗 Reference related issues
🏃 Test cases are included to exercise the new code
🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

Marwes

Mostly just style things. Haven't gone through all of it yet so will continue tomorrow.

internal/cmd/headless_repl/rust-toolchain.toml

internal/cmd/headless_repl/src/LSPSuggestionHelper.rs

internal/cmd/headless_repl/src/lib.rs

internal/cmd/headless_repl/src/LSPSuggestionHelper.rs

internal/cmd/headless_repl/src/processes/FluxServerImpl.rs

internal/cmd/headless_repl/src/processes/LSPServerImpl.rs

internal/cmd/headless_repl/src/processes/invoke_go.rs

internal/cmd/headless_repl/src/processes/lsp_invoke.rs

internal/cmd/headless_repl/main.go

internal/cmd/headless_repl/src/lib.rs

internal/cmd/headless_repl/src/processes/lsp_server_impl.rs

internal/cmd/headless_repl/src/processes/process_completion.rs

internal/cmd/headless_repl/src/processes/invoke_go.rs

…function arguments so that arg hints will be given even if there is not any overlap with what has been typed

…an be removed so that hints are not being repeated

…and over

…added to a vec

…s after an import the lsp stops giving completions for some reason

…ny of the imported packages

…now am showing suggestions if there is not a comma present with function args

…o auto suggest function args without user typing anything

… the coordinator

… are now wokring fine

…points and the regex code was simplified

… meet suggetsions

onelson

Spent some time looking things over again today and I think most of the stuff I'd like to change can be done as follow-up PRs.

The main thing will be to get this merged so we can iterate on it as time allows.

Westonside requested a review from onelson August 2, 2022 21:32

Westonside changed the title ~~Westonside/intern project/new cli/rustyline~~ Rustyline Code additions to communicate with the headless repl Aug 2, 2022

onelson changed the base branch from master to westonside/intern_proejct/new-cli August 11, 2022 03:08

Marwes reviewed Aug 15, 2022

View reviewed changes

Marwes reviewed Aug 16, 2022

View reviewed changes

onelson suggested changes Aug 20, 2022

View reviewed changes

Westonside changed the base branch from westonside/intern_proejct/new-cli to master August 26, 2022 19:38

Westonside force-pushed the westonside/intern_project/new_cli/rustyline branch from 4cb43c4 to 610d3b9 Compare August 26, 2022 19:45

Westonside changed the title ~~Rustyline Code additions to communicate with the headless repl~~ feat: Rustyline Code additions to communicate with the headless repl Aug 26, 2022

Westonside force-pushed the westonside/intern_project/new_cli/rustyline branch from 610d3b9 to 7fd0998 Compare August 26, 2022 20:09

Weston Tuescher and others added 20 commits August 29, 2022 13:26

feat: rustyline setup with the headlesss repl

2765e78

feat: Updates to the Hinttype enum and now adding basic checking for …

07bb587

…function arguments so that arg hints will be given even if there is not any overlap with what has been typed

feat: explored ways to store the recently completed hint so that it c…

3b548c5

…an be removed so that hints are not being repeated

feat: stopped giving the same suggestion for function arguments over …

9396241

…and over

fix: Now only suggest another argument if commas are present

1a01b8e

feat: added in the regex patten to capture imports that will then be …

7e434aa

…added to a vec

feat: added in retaining all the imports the user has BUT the issue i…

0cd0575

…s after an import the lsp stops giving completions for some reason

fix: allow saving imports but the lsp is not giving suggestions for a…

04fb66d

…ny of the imported packages

feat: allowed for packages functions and args to be completed. NOTE: …

22ff81d

…now am showing suggestions if there is not a comma present with function args

fix: fixes to the suggestion algorithm already huge improvement

af6ed9d

fix: added in validity checking for hints that works well, now need t…

c7a8e98

…o auto suggest function args without user typing anything

feat: added into auto completion of full hint signature

39cadce

chore: code cleanup and general tweaks trying to find good design for…

03bd915

… the coordinator

chore: code overhaul and clean up much easier to read and all threads…

c3ae414

… are now wokring fine

chore: Added a few of the suggestions on the rustyline code

39ceee4

chore: Massive code clean up warnings reduced greatly

0f6265e

fix: minor changes

e2bf5d4

fix: cargo files

f5d2418

chore: commit to rebase

2206373

fix: fixes to the lsp adding so that suggestions can be given at all …

2f69488

…points and the regex code was simplified

Weston Tuescher added 6 commits August 29, 2022 13:26

feat: add makefile and readme optimized more code and changed code to…

b343e65

… meet suggetsions

fix: Make file and code changes

9d37a5e

chore: fixes to the code and readme updates

59e00bb

fix: changed the completion parsing to be done with lsp_types

23a05b6

chore: clippy suggested changes fix

842a4c1

chore: makefile

bd09a36

onelson force-pushed the westonside/intern_project/new_cli/rustyline branch from 7fd0998 to 4c2684b Compare August 29, 2022 20:26

docs: update to readme

899c7a9

onelson force-pushed the westonside/intern_project/new_cli/rustyline branch from 4c2684b to 899c7a9 Compare August 30, 2022 00:06

onelson marked this pull request as ready for review August 30, 2022 00:07

onelson requested a review from a team as a code owner August 30, 2022 00:07

onelson approved these changes Aug 30, 2022

View reviewed changes

onelson changed the title ~~feat: Rustyline Code additions to communicate with the headless repl~~ feat: add rust binary to sit on top of "headless repl" backend Aug 30, 2022

onelson merged commit 6235ddd into master Aug 30, 2022

onelson deleted the westonside/intern_project/new_cli/rustyline branch August 30, 2022 00:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add rust binary to sit on top of "headless repl" backend #5041

feat: add rust binary to sit on top of "headless repl" backend #5041

Westonside commented Aug 2, 2022

Marwes left a comment

onelson left a comment

feat: add rust binary to sit on top of "headless repl" backend #5041

feat: add rust binary to sit on top of "headless repl" backend #5041

Conversation

Westonside commented Aug 2, 2022

Description

Checklist

Marwes left a comment

Choose a reason for hiding this comment

onelson left a comment

Choose a reason for hiding this comment