Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlib): promote various features to defaults #5005

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

jsternberg
Copy link
Contributor

@jsternberg jsternberg commented Jul 19, 2022

This promotes the narrow state tracking and limit transformations to be
the defaults and removes their old implementations.

This also turns the group transformation group and optimized aggregate
window to default to true. I'm keeping the feature flags for these two
as these ones are more likely to require an unexpected problem and I
would like to keep a way for them to be turned off quickly. These two
will likely have their old versions removed next week.

Done checklist

  • docs/SPEC.md updated
  • Test cases written

@jsternberg jsternberg requested a review from a team as a code owner July 19, 2022 20:20
@jsternberg jsternberg requested review from Westonside, wolffcm, onelson and scbrickley and removed request for a team July 19, 2022 20:20
Copy link

@wolffcm wolffcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these have been enabled for a while, yes? How long?

Copy link

@wolffcm wolffcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

This promotes the narrow state tracking and limit transformations to be
the defaults and removes their old implementations.

This also turns the group transformation group and optimized aggregate
window to default to true. I'm keeping the feature flags for these two
as these ones are more likely to require an unexpected problem and I
would like to keep a way for them to be turned off quickly. These two
will likely have their old versions removed next week.
@jsternberg jsternberg force-pushed the feat/promote-flags branch from d12ff7d to 21c6a52 Compare July 25, 2022 14:13
@jsternberg jsternberg merged commit 05a1065 into master Jul 25, 2022
@jsternberg jsternberg deleted the feat/promote-flags branch July 25, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants