fix: Handle a missing property on member expressions better #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marwes
commented
Jul 4, 2022
| "#, | ||
| ); | ||
| let parsed = p.parse_file("".to_string()); | ||
| expect_test::expect![[r#"error @4:1-4:8: expected IDENT, got BUILTIN (builtin) at 4:1"#]] |
There was a problem hiding this comment.
Before this change we would also get an error complaining about the builtin statement being invalid as the builtin token was consumed.
scbrickley
approved these changes
Aug 30, 2022
It is common for users to write `x.` in which case we should not try to consume the next, non-identifier token.
This was referenced Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common for users to write
x.and then query for completion, in which case we should not try to consume the next, non-identifier token as that will likely causing further parse failures.