fix(repl): replace extra boolean parameter for suggestions with repl options #4915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onelson
approved these changes
Jun 23, 2022
wolffcm
approved these changes
Jun 23, 2022
…options This uses the option pattern to configure the repl with enabling suggestions as the currently available option. This option defaults to false. The `repl.New()` function has also been changed back to accept only a single argument, but to also allow an optional set of options to configure the REPL.
0780bb1 to
b19002c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the option pattern to configure the repl with enabling
suggestions as the currently available option. This option defaults to
false. The
repl.New()function has also been changed back to acceptonly a single argument, but to also allow an optional set of options to
configure the REPL.
Done checklist