Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove test statements #4910

Merged
merged 3 commits into from
Jun 27, 2022
Merged

feat: Remove test statements #4910

merged 3 commits into from
Jun 27, 2022

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Jun 23, 2022

With all test statements being converted to testcase and neither being used outside of
testing flux (right? no one else is using either?). We can safely remove this old way of writing tests.

Closes #4768

@Marwes Marwes requested a review from a team as a code owner June 23, 2022 09:34
@Marwes Marwes requested review from OfTheDelmer and removed request for a team June 23, 2022 09:34
@Marwes Marwes requested a review from a team as a code owner June 23, 2022 15:29
@Marwes Marwes requested review from jstirnaman and removed request for a team June 23, 2022 15:29
@Marwes Marwes mentioned this pull request Jun 23, 2022
Closed
7 tasks
nathanielc
nathanielc approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@nathanielc nathanielc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I am confident no one outside the Flux repo is using the test statement. I checked with the edge team earlier this week to be safe.

Markus Westerlind added 3 commits June 27, 2022 11:11
feat: Remove test statements
b250941 
With all `test` statements being converted to `testcase` and neither being used outside of
testing flux (right? no one else is using either?). We can safely remove this old way of writing tests.

Closes #4768
feat: Remove testing.benchmark/inspect/run
6f78151 
These seem to depend on the `test` statement so without it, they have no purpose.
chore: make generate
bede6c7
@Marwes Marwes force-pushed the remove_test_stmtm branch from 9529c63 to bede6c7 Compare June 27, 2022 09:11
@Marwes Marwes merged commit 02f463f into master Jun 27, 2022
@Marwes Marwes deleted the remove_test_stmtm branch June 27, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielc nathanielc nathanielc approved these changes

@OfTheDelmer OfTheDelmer Awaiting requested review from OfTheDelmer OfTheDelmer was automatically assigned from influxdata/flux-team

@jstirnaman jstirnaman Awaiting requested review from jstirnaman jstirnaman is a code owner automatically assigned from influxdata/docs-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert All End to End Test to Acceptance Tests
2 participants
@Marwes @nathanielc