Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repl): Suggestions now start off by default and added a new flag #4891

Merged
merged 3 commits into from
Jun 16, 2022

Conversation

Westonside
Copy link
Contributor

Description

Added in a new flag to run the repl with suggestions and by default the real will start without suggestions. Addressed issue #4836. Updated docs to remove old argument in running the repl and showed how to run repl with the new flag.

Usage

With suggestions:

./repl --enable-suggestions

Without suggestions :

./repl

Done checklist

  • docs/SPEC.md updated
  • Test cases written

… to enable the suggestions. Fixed docs to remove repl argument and added in section on how to run repl with suggestions
@Westonside Westonside requested a review from onelson June 16, 2022 19:48
@Westonside Westonside requested a review from a team as a code owner June 16, 2022 19:48
Copy link
Contributor

@onelson onelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was there a related update to README.md coming?

@Westonside Westonside merged commit 5f12b25 into master Jun 16, 2022
@jacobmarble jacobmarble deleted the westonside/feat/remove-suggestions-flag branch January 4, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants