feat(date): add builtin function time to the date package to convert any timeable into datetime (#4749) #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skartikey
approved these changes
Jun 10, 2022
stdlib/date/date_test.flux
Outdated
| testcase time_location { | ||
| option location = timezone.location(name: "Asia/Kolkata") | ||
|
|
||
| want = array.from(rows: [{_value: 2021-03-01T05:30:00Z}]) |
There was a problem hiding this comment.
please rename the field _value to time for readability.
Modified buildinfo.gen.go to resolve the error with make checkgenerate
Added documentation for location parameter in the date.flux file. This fixes make checkdocs
Modified buildinfo.gen.go to resolve the error with make checkgenerate
sanderson
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature addition now addresses the need for a function as part of the date package to be able to convert any Timeable into a datetime.
fixes: #4749
Done checklist