fix(gen/tables): passing seed to tables generator #4866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35bab66 to
9e77d56
Compare
Adding seed to tables generator to get the very same sequence each time(helpful in writing test) at the moment the seed defaults to the current time, which generates a different sequence each time. useful in #4307
Marwes
suggested changes
Jun 10, 2022
stdlib/internal/gen/tables.go
Outdated
| @@ -26,6 +26,7 @@ type TablesOpSpec struct { | |||
| N int `json:"n"` | |||
| Tags []Tag `json:"tags,omitempty"` | |||
| Nulls float64 `json:"nulls,omitempty"` | |||
| Seed int64 `json:"Seed,omitempty"` | |||
There was a problem hiding this comment.
I think you will want this to be a pointer, otherwise omitting the seed parameter default to using 0 as the seed.
There was a problem hiding this comment.
Thanks for catching that @Marwes
stdlib/internal/gen/tables.go
Outdated
| @@ -116,6 +123,7 @@ func newTablesProcedure(qs flux.OperationSpec, pa plan.Administration) (plan.Pro | |||
| schema := gen.Schema{ | |||
| NumPoints: spec.N, | |||
| Nulls: spec.Nulls, | |||
| Seed: &spec.Seed, | |||
There was a problem hiding this comment.
This should be nil if the seed is not specified in the function call
sanderson
approved these changes
Jun 10, 2022
Marwes
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding seed to tables generator to get the very same sequence each time(helpful in writing test)
at the moment the seed defaults to the current time, which generates a different sequence each time.
useful in #4307
Done checklist