Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pagerduty): add a _status tag to pagerduty records #4796

Merged
merged 1 commit into from
May 31, 2022

Conversation

gavincabbage
Copy link
Contributor

@gavincabbage gavincabbage commented May 26, 2022

Add an additional field to the notification record written when sending PagerDuty alerts. The aim of this change is to provide visibility into cases where _sent is false and users are unable to diagnose why.

Done checklist

  • docs/SPEC.md updated (note: appears to not be applicable)
  • Test cases written (note: no tests are present today and I assume that has to do with the side effects of this call- please advise how I can add some tests for this if deemed necessary)

@brettbuddin
Copy link
Contributor

brettbuddin commented May 27, 2022

I'd be interested to see if we could eventually make use of the newer experimental/http/requests package in these notify destination packages. We'd love to capture as much information as we can about our interaction with the upstream services as we can for users to leverage in _monitoring.

@gavincabbage gavincabbage force-pushed the feat/pagerduty/status branch from 654364c to 7f3eddf Compare May 27, 2022 02:15
@gavincabbage gavincabbage marked this pull request as ready for review May 27, 2022 02:37
@gavincabbage gavincabbage requested review from a team as code owners May 27, 2022 02:37
@gavincabbage gavincabbage requested review from jsternberg and sunbryely-influxdata and removed request for a team May 27, 2022 02:37
@sanderson sanderson requested review from sanderson and removed request for sunbryely-influxdata May 27, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants