feat(execute): refactor the operator profile to be in the statistics #4791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cac57c to
ed5adfd
Compare
The operator profile is now always computed and it is part of the `flux.Statistics` struct that is returned by the query. The operator profile now uses that to return the profile instead of using Go channels and the execution dependency injected into the context. This allows the results of the operator profile to be present without it being tied directly to the profiler return. It has also been refactored to remove the use of channels for sending span data and aggregating in a goroutine to instead just aggregate the results as part of the source/transport code. This should simplify and speed up those calculations as the overall time should be equivalent but without the overhead of Go channels and only requiring a short-lived lock for appending the source profiles in the executor.
ed5adfd to
4f79185
Compare
scbrickley
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator profile is now always computed and it is part of the
flux.Statisticsstruct that is returned by the query. The operatorprofile now uses that to return the profile instead of using Go channels
and the execution dependency injected into the context.
This allows the results of the operator profile to be present without it
being tied directly to the profiler return.
It has also been refactored to remove the use of channels for sending
span data and aggregating in a goroutine to instead just aggregate the
results as part of the source/transport code. This should simplify and
speed up those calculations as the overall time should be equivalent but
without the overhead of Go channels and only requiring a short-lived
lock for appending the source profiles in the executor.
Done checklist