feat: Provide the comments for each Symbol from PackageExports #4774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#4537 might be needed also to make symbols more accurate in the LSP |
OfTheDelmer
approved these changes
Jun 21, 2022
added 5 commits
June 21, 2022 15:54
When iterating the normal hashmap we would try to order the bindings by their names, however that still left an inconsistency when we multiple bindings with the same name. Using an indexmap we will always iterate over the bindings in the order that they were inserted in, ensuring consistency
750edac to
a33d8f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the
PackageExportstype to store the comments for each exported symbol. Main use case is that LSP as I believe it should be able to use this to lookup the documentation for any exported standard library function and return it as part of a completion item (cc @rockstar , may need some work on the completion side but you may already be working on improving that(?)). Longer term I would like to also providesymbol -> attributelookup through the same API.Separated from #4773 / #4740 as I realized I didn't really need this part yet.