feat(stdlib): added timezone support to hourSelection function #4757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolffcm
suggested changes
May 16, 2022
stdlib/universe/hour_selection.go
Outdated
| } | ||
|
|
||
| return name.Str(), offset.Duration(), nil | ||
| } |
There was a problem hiding this comment.
Is this copied and pasted from a function in the date package? Maybe that function could just be exported?
| ) | ||
|
|
||
| testing.diff(got: got, want: want) | ||
| } |
There was a problem hiding this comment.
This looks good. I checked that 2018-12-19T18:11:35Z is within the 9-10 range in LA time, and it turns out that is 10:11 in LA time. But the semantics of hourSelection is that the stop hour is inclusive. This was a surprise to me! So this looks good.
f2bdd0f to
e668300
Compare
issue - hourSelection() function not respecting timezone setting
fixes: influxdata/EAR#3213
e668300 to
7eeac7a
Compare
wolffcm
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue - hourSelection() function not respecting timezone setting
fixes: influxdata/EAR#3213
Done checklist