fix: Point to the function being piped to on argument mismatches (#4882)

* fix: Point to the function being piped to on argument mismatches * chore: make generate
influxdata · Jun 15, 2022 · 7e3789a · 7e3789a
1 parent 1c65530
commit 7e3789a
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 2 deletions.
diff --git a/libflux/flux-core/src/semantic/nodes.rs b/libflux/flux-core/src/semantic/nodes.rs
@@ -1433,7 +1433,7 @@ impl CallExpr {
         if let Some(p) = &self.pipe {
             pipe = Some(types::Property {
                 k: "<-".to_string(),
-                v: (p.type_of(), p.loc()),
+                v: (p.type_of(), &self.loc),
             });
         }
 

diff --git a/libflux/flux-core/src/semantic/tests.rs b/libflux/flux-core/src/semantic/tests.rs
@@ -4221,3 +4221,30 @@ fn vec_type() {
         ],
     }
 }
+
+#[test]
+fn pipe_error() {
+    test_error_msg! {
+        config: AnalyzerConfig{
+            features: vec![Feature::UnusedSymbolWarnings],
+            ..AnalyzerConfig::default()
+        },
+        env: map![
+            "findColumn" =>  "() => [A] where A: Record",
+            "yield" => "(<-tables: stream[A]) => stream[A] where A: Record",
+        ],
+        src: r#"
+
+            findColumn()
+                |> yield()
+        "#,
+        expect: expect_test::expect![[r#"
+            error: expected stream[A] but found [A] (array) (argument tables)
+              ┌─ main:4:20
+              │
+            4 │                 |> yield()
+              │                    ^^^^^^^
+
+        "#]]
+    }
+}
diff --git a/libflux/go/libflux/buildinfo.gen.go b/libflux/go/libflux/buildinfo.gen.go
@@ -48,7 +48,7 @@ var sourceHashes = map[string]string{
 	"libflux/flux-core/src/semantic/import.rs":                                                    "184e955211db1ceb1be782b4daf75584b86907b1428e50015497909cfc2dd89a",
 	"libflux/flux-core/src/semantic/infer.rs":                                                     "9d4293f2471a90cc89c1e45cdc72082e0da1a484981b803aea05856e6b4d722f",
 	"libflux/flux-core/src/semantic/mod.rs":                                                       "a70c32d73f0053e4a3eda7ad23626252cf6420b5db8b440a7351c2f62aa7a948",
-	"libflux/flux-core/src/semantic/nodes.rs":                                                     "23ee2dec99b71f0fe81987528b3dfbd95e89d77a274ccc8a0baa146dea89ad51",
+	"libflux/flux-core/src/semantic/nodes.rs":                                                     "d41e326b30823b643b0b193df7ac35217255ec0034a5ba2b61ca15e1abd58233",
 	"libflux/flux-core/src/semantic/sub.rs":                                                       "a989e50c113ca899fe02f8d49a4744a420580a3f803f656db25beb2d0c2a247b",
 	"libflux/flux-core/src/semantic/symbols.rs":                                                   "ddbceca632ca384c6bb461a660e02781c43295025f2dd10f1ea997131dd5eb30",
 	"libflux/flux-core/src/semantic/types.rs":                                                     "ed414b695e925f18f74984ec88bba652ef8dd8c9e905cb9e8fa19b101a4601b4",