Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add benchmark table again #4363

Merged
merged 2 commits into from
Jan 25, 2025
Merged

feat: add benchmark table again #4363

merged 2 commits into from
Jan 25, 2025

Conversation

fraidev
Copy link
Contributor

@fraidev fraidev commented Jan 25, 2025 •
edited
Loading

image

@fraidev fraidev requested a review from sehz January 25, 2025 03:06
@fraidev fraidev marked this pull request as ready for review January 25, 2025 03:16
sehz
sehz reviewed Jan 25, 2025
View reviewed changes
crates/fluvio/src/producer/accumulator.rs
@@ -126,7 +128,7 @@ impl RecordAccumulator {

// Create and push a new batch if needed
let push_record = self
.create_and_new_batch(batch_events, &mut batches, record, 1)
.create_and_new_batch(batch_events, &mut batches, record, 1, created_at)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit unclear whether latency is account for but should be better than now

@fraidev fraidev added this pull request to the merge queue Jan 25, 2025
Merged via the queue into infinyon:master with commit 3bf5c57 Jan 25, 2025
102 checks passed
@fraidev fraidev deleted the benchmark_table branch January 25, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fraidev @sehz