cleanup fbm #4315
Merged
cleanup fbm #4315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
060d489 to
6cdfa0f
Compare
provide defaults for high performance
6cdfa0f to
16b45f9
Compare
Closed
fraidev
reviewed
Jan 14, 2025
| Ok(()) | ||
| } | ||
| pub async fn run_benchmark(config: BenchmarkConfig, all_stats: AllStatsSync) -> Result<()> { | ||
| pub async fn run_benchmark(config: BenchmarkConfig) -> Result<()> { | ||
| // Create topic for this run | ||
|
|
||
| let new_topic = TopicSpec::new_computed(config.num_partitions as u32, 1, None); |
There was a problem hiding this comment.
Maybe we can create the topic and the connection inside the producer, but no block, I can do this on the next PR
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
focus fbm to only on producer performance test. Remove code related to consumer testing which will be brought back later.