Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest version support for Axios ? #307

Closed
AmalMenachery opened this issue Apr 11, 2023 · 2 comments · Fixed by #311
Closed

Latest version support for Axios ? #307

AmalMenachery opened this issue Apr 11, 2023 · 2 comments · Fixed by #311
Labels
released

Comments

@AmalMenachery
Copy link

AmalMenachery commented Apr 11, 2023 •
edited
Loading

We have this latest release v3.0.0, which mentions about breaking changes from Axios : https://github.com/infinitered/apisauce/releases/tag/v3.0.0

However in the package.json https://github.com/infinitered/apisauce/blob/master/package.json we still have
"dependencies": { "axios": "^0.27.2" },

Could someone look into it ?
@moxorama
Copy link

moxorama commented Jun 1, 2023

At least there should be some TypeScript corrections

Type 'import("<>/node_modules/apisauce/node_modules/axios/index").AxiosRequestConfig<any>' is not assignable to type 'import("<>/node_modules/axios/index").AxiosRequestConfig<any>'

@jamonholmgren jamonholmgren mentioned this issue Jun 15, 2023
Merged
jamonholmgren added a commit that referenced this issue Jun 17, 2023
@jamonholmgren
fix: Upgrades axios to 1.4.0 and fixes Node v17+ ipv6 issue in tests (#…
7665879 
…311 by @jamonholmgren)

fixes #307
infinitered-circleci pushed a commit that referenced this issue Jun 17, 2023
@semantic-release-bot
chore(release): 3.0.1 [skip ci]
e405871 
## [3.0.1](v3.0.0...v3.0.1) (2023-06-17)

### Bug Fixes

* Upgrades axios to 1.4.0 and fixes Node v17+ ipv6 issue in tests ([#311](#311) by [@jamonholmgren](https://github.com/jamonholmgren)) ([7665879](7665879)), closes [#307](#307)
@infinitered-circleci
Copy link

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Upgrades axios to 1.4.0 and fixes Node v17+ ipv6 issue in tests infinitered/apisauce
3 participants
@moxorama @AmalMenachery @infinitered-circleci