Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class attribute failure #117

Closed
wants to merge 7 commits into from
Closed

Class attribute failure #117

wants to merge 7 commits into from

Conversation

bknoles
Copy link
Collaborator

@bknoles bknoles commented Apr 29, 2024

No description provided.

ledermann and others added 7 commits June 28, 2021 06:43
Move code to InertiaRails::Controller and use `class_attribute`
to manage definitions without affecting parent controller.

This avoids resetting shared data (`InertiaRails.reset!`) on
every request. Instead, the shared data is defined at class loading.

This change is thread-safe by design, so the multi-threading-test
is removed.
@bknoles bknoles mentioned this pull request Apr 29, 2024
@bknoles
Copy link
Collaborator Author

bknoles commented Jun 19, 2024

closing since this was just an edge case example for the discussion in #111

@bknoles bknoles closed this Jun 19, 2024
@BrandonShar BrandonShar deleted the class-attribute-failure branch October 29, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants