ninja: handle CONFIGURATION_NAME edge case
#35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icu-generic.gyp has the phrase `'../../<(CONFIGURATION_NAME)'` that doesn't resolve correctly in the generated ninja
srl295
reviewed
Feb 23, 2017
| @@ -140,6 +140,8 @@ Ninja.prototype.expand = function expand(p, productDir) { | |||
| p = p.replace(/\$!INTERMEDIATE_DIR/g, intDir); | |||
| } | |||
|
|
|||
| // First one is in order to outsmart silly GYP file writers | |||
There was a problem hiding this comment.
silly is fine. 🙃
But I'd also plead "under-informed" here.
There was a problem hiding this comment.
ninja is my friend. gyp is not my friend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #34
until nodejs/node#11217 lands