Skip to content

Commit

Permalink
fix: gyp allows spaces in action names. ninja doesn't
Browse files Browse the repository at this point in the history
  • Loading branch information
refack authored Feb 5, 2017
1 parent 7885e7f commit c1fbf87
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/gyp/generator/ninja/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ Ninja.prototype.actions = function actions() {

let res = [];
list.forEach((action) => {
const actionRule = action.action_name + '_' + this.index;
const actionRule = action.action_name.replace(/\s/g, '_') + '_' + this.index;

const base = gyp.common.cachedRelative(this.configDir, this.srcDir);
const toBase = gyp.common.cachedRelative(this.srcDir, this.configDir);
Expand Down

0 comments on commit c1fbf87

Please sign in to comment.