fix-win: /STACK argument syntax

indutny · Feb 6, 2017 · a0e19f8 · a0e19f8
1 parent ea66223
commit a0e19f8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/gyp/platform/win.js b/lib/gyp/platform/win.js
@@ -236,7 +236,7 @@ function linkerFlags(linker) {
     if (stack_reserve_size) {
       let stack_commit_size = linker.StackCommitSize || '';
       if (stack_commit_size) stack_commit_size = ',' + stack_commit_size;
-      ldflags.push('/STACK' + stack_reserve_size + stack_commit_size);
+      ldflags.push('/STACK:' + stack_reserve_size + stack_commit_size);
     }
 
     ld('TerminalServerAware', {

diff --git a/test/platform-win-test.js b/test/platform-win-test.js
@@ -31,7 +31,7 @@ describe('gyp.platform.win', () => {
 
     it('should preserve quotes', () => {
       assert.deepEqual(
-        win.adjustLibraries([ '"some path/lib1"', '-l"lib2"', 
+        win.adjustLibraries([ '"some path/lib1"', '-l"lib2"',
                              '-l"lib3.lib"', '"lib4.lib"' ]),
         [ '"some path/lib1.lib"', '"lib2.lib"', '"lib3.lib"', '"lib4.lib"' ]);
     });
@@ -175,7 +175,7 @@ describe('gyp.platform.win', () => {
         '/MAPINFO:EXPORTS',
         '/XXX', '/YYY',
         '/SUBSYSTEM:WINDOWS,7',
-        '/STACK100,200',
+        '/STACK:100,200',
         '/TSAWARE:NO',
         '/INCREMENTAL',
         '/BASE:1000',