Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyBuilder: warn on encountering NaN #288

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Conversation

matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented Feb 5, 2025

Partially addresses #287 .

Please squash

@matthiasdiener
Copy link
Contributor Author

What do you think of this @inducer?

@matthiasdiener matthiasdiener marked this pull request as ready for review February 5, 2025 20:40
@inducer inducer merged commit ffc793c into inducer:main Feb 5, 2025
17 checks passed
@inducer
Copy link
Owner

inducer commented Feb 5, 2025

LGTM, thanks!

@matthiasdiener matthiasdiener deleted the keyb-nan branch February 5, 2025 21:11
This was referenced Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants