setup.py: add headers as dependencies #596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, modifications to header files do not trigger a rebuild.
|
Sorry, no. distutils is not smart enough to gather dependencies in the way a reasonable build tool might. In addition, this is a half-measure: There are many other headers that really ought to be watched for changes. #546 uses cmake to build, which solves this without having to clutter up |
|
To further explain: The only reliable way to build of which I'm aware is to start from scratch every time, i.e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, modifications to header files do not trigger a
rebuild.
See also https://docs.python.org/3/distutils/setupscript.html#other-options