Port deprecated urwid accessors

[alexfikl]

urwid started being a bit more vocal about deprecations in urwid/urwid@8a0a6d1. The recommended variants (e.g. w.focus vs w.get_focus()) seem to have been around for a while, so this just ports everything to use the property-based interface.

I am very unsure this is correct, so probably needs some proper testing or a knowledgeable reviewer. I tried using most shortcuts I know and opening things (variables, stack, breakpoints, etc) and it seems to work.

[alexfikl]

The deprecations from urwid started being spammed in the command line widget. Is that intended?

EDIT: I have PYTHONWARNINGS=default set in the environment, so this is not something that would normally happen.

[inducer]

The deprecations from urwid started being spammed in the command line widget. Is that a intended?

It's not not intended. :) It's certainly better than having them land on just stdout/stderr (where they would haphazardly overwrite the UI).

[alexfikl]

@inducer This should be good to go for a review.

[inducer]

Do we know when urwid introduced these constants? (And should we set a version bound to make sure we have them?)

[alexfikl]

Do we know when urwid introduced these constants? (And should we set a version bound to make sure we have them?)

Do you mean those urwid.WEIGHT things? Those were introduced over a decade ago, e.g. in
urwid/urwid@05e1e6d#diff-29a00abb3c654d8ca892d9b10e535a2342f0e403192cbcf8f164420fe66f8bc8
but some seem to be older. The properties like widget.focus seem to also have been mostly introduced a long time ago, e.g. in
urwid/urwid@e3e013f

So it seems safe to just let them be at this point?

[inducer]

Agreed. Thanks!

[inducer]

Turns out this was still quite broken in places. #604 fixes up the issues that I'm aware of.

[alexfikl]

Turns out this was still quite broken in places. #604 fixes up the issues that I'm aware of.

Ouf, sorry about that (and thanks for fixing it)! Feel free to ping me if something's still broken 😞