change isinstance(..., frozenset) to abc_Set, pt2 #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kaushikcfd
reviewed
Feb 16, 2024
| @@ -195,7 +196,8 @@ class TranslationUnit: | |||
| entrypoints: FrozenSet[str] | |||
|
|
|||
| def __post_init__(self): | |||
| assert isinstance(self.entrypoints, frozenset) | |||
|
|
|||
| assert isinstance(self.entrypoints, abc_Set) | |||
There was a problem hiding this comment.
Could you please explain why this is needed? Thanks!
There was a problem hiding this comment.
Sure, these changes are necessary for compatibility with alternative set implementations, in particular https://github.com/matthiasdiener/orderedsets.
ed43019 to
a9f7d29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.