bug fix: Serilisation fix when using ement range notation in path sho…

…uld take into account the min bound. #170
indice-co · Oct 8, 2020 · a0bb927 · a0bb927
1 parent 8899926
commit a0bb927
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/src/indice.Edi/EdiSerializer.cs b/src/indice.Edi/EdiSerializer.cs
@@ -811,6 +811,10 @@ private static void SerializeStructure(EdiWriter writer, Stack<EdiStructure> sta
                         } else {
                             itemType = property.Info.PropertyType.GetGenericArguments().First();
                         }
+                        int range_offset = 0;
+                        if (container == EdiStructureType.Element && property.PathInfo.PathInternal.Element.IsRange) {
+                            range_offset = property.PathInfo.PathInternal.Element.Min;
+                        }
                         for (var i = 0; i < collection.Count; i++) {
                             var item = collection[i];
                             if (stack.Count == 0) {
@@ -819,7 +823,7 @@ private static void SerializeStructure(EdiWriter writer, Stack<EdiStructure> sta
                             while (stack.Peek().StructureType >= container) {
                                 var previous = stack.Pop();
                             }
-                            stack.Push(new EdiStructure(container, stack.Peek(), property, item, i, null));
+                            stack.Push(new EdiStructure(container, stack.Peek(), property, item, range_offset + i, null));
                             SerializeStructure(writer, stack, structuralComparer);
                         }
                     } else {

diff --git a/test/indice.Edi.Tests/SerializerTests.cs b/test/indice.Edi.Tests/SerializerTests.cs
@@ -235,6 +235,28 @@ public void Serialize_ElementList() {
             Assert.Equal(expected, output);
         }
 
+        [Fact, Trait(Traits.Tag, "EDIFact"), Trait(Traits.Issue, "#170")]
+        public void Serialize_ElementList_WithRanged_Path() {
+            var grammar = EdiGrammar.NewEdiFact();
+            var interchange = default(EdiFact_Issue170_ElementList);
+            using (var stream = Helpers.GetResourceStream("edifact.Issue170.ElementList.edi")) {
+                interchange = new EdiSerializer().Deserialize<EdiFact_Issue170_ElementList>(new StreamReader(stream), grammar);
+            }
+
+            var expected = new StringBuilder()
+            .AppendLine("UNA:+.? '")
+            .AppendLine("IFT+1:1+This+is+the first'")
+            .AppendLine("IFT+1:2+And+this is+the seccond'")
+            .AppendLine("IFT+1:3+while+this+should come third'").ToString();
+            string output = null;
+            using (var writer = new StringWriter()) {
+                new EdiSerializer().Serialize(writer, grammar, interchange);
+                output = writer.ToString();
+            }
+
+            Assert.Equal(expected, output);
+        }
+
         [Fact(Skip = "Not implemented yet"), Trait(Traits.Tag, "Tradacoms"), Trait(Traits.Issue, "#17")]
         public void Should_Serialize_Autogenerated_Counts() {
             var grammar = EdiGrammar.NewTradacoms();