Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start delay in workflow start options #376

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

duoertai
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 71.91%. Comparing base (f439d10) to head (46f52ae).
Report is 1 commits behind head on main.

Files Patch % Lines
service/api/service.go 0.00% 3 Missing and 1 partial ⚠️
service/api/cadence/client.go 0.00% 2 Missing and 1 partial ⚠️
service/api/temporal/client.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   72.06%   71.91%   -0.15%     
==========================================
  Files          56       56              
  Lines        5004     5014      +10     
==========================================
  Hits         3606     3606              
- Misses       1132     1139       +7     
- Partials      266      269       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duoertai duoertai requested a review from longquanzheng March 19, 2024 17:55
@duoertai
Copy link
Collaborator Author

Screenshot 2024-03-20 at 3 14 14 AM

tested with 10s delay

Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a test?

@duoertai duoertai merged commit d295ead into indeedeng:main Mar 21, 2024
4 of 6 checks passed
@duoertai
Copy link
Collaborator Author

maybe add a test?

sry, merged before I saw this comment. I checked the current APIs, it seems that workflow start time is not included in any response(get, getWithWait, search), is there a good way to add test for this? Shall we add start time in the API response?

@duoertai
Copy link
Collaborator Author

maybe add a test?

let me try to use temporal describe api to get the actual start time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants