Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve waitForStateCompletion API reliability for signalWithStart order #354

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

longquanzheng
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #354 (4ca9d36) into main (dad8c61) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

❗ Current head 4ca9d36 differs from pull request most recent head 23b57d1. Consider uploading reports for the commit 23b57d1 to get more accurate results

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   72.53%   72.51%   -0.02%     
==========================================
  Files          56       56              
  Lines        4900     4912      +12     
==========================================
+ Hits         3554     3562       +8     
- Misses       1089     1091       +2     
- Partials      257      259       +2     
Files Coverage Δ
service/interpreter/interfaces.go 73.33% <ø> (ø)
service/interpreter/activityImpl.go 77.50% <66.66%> (-0.22%) ⬇️
service/interpreter/cadence/workflowProvider.go 72.22% <66.66%> (-0.39%) ⬇️
service/interpreter/temporal/workflowProvider.go 73.95% <66.66%> (-0.38%) ⬇️
service/interpreter/workflowImpl.go 81.79% <82.35%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

})
if err != nil {
// for any reasons this fail, just panic and the workflow task will retry
panic(fmt.Sprintf("failed to signal on completion %w", err))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errorf?

@longquanzheng longquanzheng merged commit 8f84a32 into main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants